New Github/Gitea Label
I'd like to introduce `Refactoring` as a new label. I feel like we should distinguish between "real" enhancements and "just" refactorings. What do you say?
Friendica Developers reshared this.
I feel like most current issue labels are meaningless beyond the Bug label we use to prioritize issues during the RC period.
So it wouldnโt do any harm to add another one, but it wonโt help with any existing workflow either.
Locks with hostname
!Friendica Developers
Calling @Hypolite Petovan and @Michael Vogel for support at github.com/friendica/friendicaโฆ
I do want to alter the way how locks are working to make parallel hosts/nodes possible. I think the logic itself is pretty straight forward and final.
BUT - how can I upgrade the lock table without using it during the update process itself, it's a gordon knot
I think about using a new method at DBStructure
: github.com/friendica/friendicaโฆ and execute it before using the lock.
Do you think it works? At least my local nodes are working, but I'm totally unsure about it yet ..
I'd like to finish this PR for 2021.12 as another preparation for making Friendica "cluster ready" :D
Add hostname to Locks by nupplaphil ยท Pull Request #10601 ยท friendica/friendica
Superseded #9114 This should help with #9095 We now add the hostname to each lock as well. The hostname is detected based on either uname -n or per environment variable NODE_NAME. This will have th...GitHub
Friendica Developers reshared this.
Questions Depository
!Friendica Developers
Calling @Hypolite Petovan for help
Why did you introduce a separate "Navigation" directory under "src"?
My guess: this is really a DDD practice using a directory for a use cases and define the different class-types under it (creating boundaries between differently purposed code). But if so, why don't you include the Modules/Notification as well?
And "Navigation/Notification" triggers for me, that the focus of this class is only the notifications at the top of the navbar, am I right?
I'm trying to follow your pattern and refactor the ProfileField / PermissionSet.
Would it be a new "src":
"src/Profile" , where PermissionSet and ProfileField are Entities/ValueObjects ? Or how would you structure these repositories/models?
Friendica Developers reshared this.
Aaahh sounds like the "good old" Model View Controller (MVC) pattern:
- Model --> where the business logic is (=> Entity, Depository, ...)
- View --> the presentation layer (=> Renderer / smarty templates)
- Controller --> The logic to show the right business logic (glue between model & view) (=> Modules)
=> And I like it
I'll give it a try after finishing the WebDav class
Philipp Holzer
Unknown parent • •Philipp Holzer
Unknown parent • •Philipp Holzer
Unknown parent • •Fabiรกn LU4EHF
Unknown parent • • •Test Post
Philipp Holzer likes this.
Hypolite Petovan
in reply to Philipp Holzer • • •like this
Philipp Holzer, Marco R. and Damien Goutte-Gattat like this.
Philipp Holzer
in reply to Hypolite Petovan • •Philipp Holzer
Unknown parent • •d778af0b0ee3462d6cff943e0a8d8a9a5364c67f
What I did: