Skip to main content


in reply to Hypolite Petovan

haha, I think I will try to call her with that name and see what happens :D
Unknown parent

Philipp Holzer

d778af0b0ee3462d6cff943e0a8d8a9a5364c67f
What I did:

  • Clicked at "Friendica Developers" under "Forums" inside the left navbar
  • Opened a new Topic per pencil-button


New Github/Gitea Label


!Friendica Developers
I'd like to introduce `Refactoring` as a new label. I feel like we should distinguish between "real" enhancements and "just" refactorings. What do you say?

Friendica Developers reshared this.

in reply to Philipp Holzer

I feel like most current issue labels are meaningless beyond the Bug label we use to prioritize issues during the RC period.

So it wouldnโ€™t do any harm to add another one, but it wonโ€™t help with any existing workflow either.

Unknown parent

Hypolite Petovan
We never had any regression issue during refactoring tasks. ๐Ÿคฅ


Locks with hostname


!Friendica Developers
Calling @Hypolite Petovan and @Michael Vogel for support at github.com/friendica/friendicaโ€ฆ

I do want to alter the way how locks are working to make parallel hosts/nodes possible. I think the logic itself is pretty straight forward and final.

BUT - how can I upgrade the lock table without using it during the update process itself, it's a gordon knot :-/
I think about using a new method at DBStructure: github.com/friendica/friendicaโ€ฆ and execute it before using the lock.

Do you think it works? At least my local nodes are working, but I'm totally unsure about it yet ..

I'd like to finish this PR for 2021.12 as another preparation for making Friendica "cluster ready" :D

This entry was edited (3 years ago)

Friendica Developers reshared this.

in reply to Philipp Holzer

Any idea @Michael Vogel ? :) I'm really stuck here and it's one major piece in the puzzle to make Friendica cluster-ready ;-)
Unknown parent

@Michael Vogel @Hypolite Petovan @Friendica Developers but wouldn't that possibly create a race condition, because a 2nd worker would start another update and wouldn't find the lock anymore so update it again?


Questions Depository


!Friendica Developers
Calling @Hypolite Petovan for help :-)

Why did you introduce a separate "Navigation" directory under "src"?

My guess: this is really a DDD practice using a directory for a use cases and define the different class-types under it (creating boundaries between differently purposed code). But if so, why don't you include the Modules/Notification as well?
And "Navigation/Notification" triggers for me, that the focus of this class is only the notifications at the top of the navbar, am I right?
I'm trying to follow your pattern and refactor the ProfileField / PermissionSet.

Would it be a new "src":
"src/Profile" , where PermissionSet and ProfileField are Entities/ValueObjects ? Or how would you structure these repositories/models?

This entry was edited (3 years ago)

Friendica Developers reshared this.

in reply to Philipp Holzer

Aaahh sounds like the "good old" Model View Controller (MVC) pattern:
- Model --> where the business logic is (=> Entity, Depository, ...)
- View --> the presentation layer (=> Renderer / smarty templates)
- Controller --> The logic to show the right business logic (glue between model & view) (=> Modules)
=> And I like it :-)

I'll give it a try after finishing the WebDav class ;-)


โ‡ง