Friendica Developers reshared this.
Questions about /display/
!Friendica Developers
@Michael Vogel - I'm currently moving the
As far as I can see, there are two main-routes for this controller:
and as far as I can say, it would be better if the second route should have an own root, like `dfrn_item/{uri-id}[/conversation.atom`, as it's a DFRN only logic.
Am I right so far?
If so, can I move it to this new path or is this path necessary for the federation usage, means it could be called from other servers too?
I just found calls with prefix
@Michael Vogel - I'm currently moving the
mod/display.php
As far as I can see, there are two main-routes for this controller:
-
/display/{guid}
-
/display/feed-item/{uri-id}.atom[/conversation.atom]
and as far as I can say, it would be better if the second route should have an own root, like `dfrn_item/{uri-id}[/conversation.atom`, as it's a DFRN only logic.
Am I right so far?
If so, can I move it to this new path or is this path necessary for the federation usage, means it could be called from other servers too?
I just found calls with prefix
DI::baseUrl()
, so I guess it's "just" for the server itself, but I'm not sure ...
Friendica Developers reshared this.
Michael Vogel
•Friendica Developers reshared this.
Hypolite Petovan
•/display/{guid}
/display/feed-item/{uri-id}[.atom]
/display/feed-item/{uri-id}/conversation.atom
Philipp Holzer likes this.
Friendica Developers reshared this.
Michael Vogel
•This has nothing to do with DFRN. This is just an ATOM link.
friendica/display.php at develop ยท friendica/friendica
GitHubPhilipp Holzer likes this.
Friendica Developers reshared this.
Philipp Holzer
•DFRN::itemFeed()
call.I think I let the routes as-is because I'm not sure what changing the route would mean to ATOM users ...
Hypolite Petovan likes this.
Friendica Developers reshared this.
Philipp Holzer
•mod/update_display.php
And I don't find any occurrence of a link, like
/update_display?p=<profileid>
.Do you know where it is used ?
Friendica Developers reshared this.
Hypolite Petovan
•friendica/display.php at b1eba05e931dd27c301b5df2bc314edffeffb10c ยท friendica/friendica
GitHubFriendica Developers reshared this.
Philipp Holzer
•*_content
route and thought the only place, where it's called is atupdate_display
Hypolite Petovan likes this.
Friendica Developers reshared this.
Philipp Holzer
•Friendica Developers reshared this.
Philipp Holzer
•I still struggle at
mod/update_display.php
It's the only place, where the
display_content
frommod/display.php
is called with the parameter$update = true
.But I don't find any place inside Friendica, where we call
/update_display?p=<profile_uid>
.Do you know if this is till in use and if so, what's the meaning of it?
If we wouldn't use it anymore, there's a lot of code at
mod/display.php
, which I could delete in that case..Friendica Developers reshared this.
Philipp Holzer
•https://github.com/friendica/friendica/blob/4a626ef10176a6f4fca0367cd890f836c2ade44a/src/Content/Conversation.php#L498-L505
and then
https://github.com/friendica/friendica/blob/b002f6f027cce0d9901c5129470e5cf41bb334c4/view/js/main.js#L595
friendica/Conversation.php at 4a626ef10176a6f4fca0367cd890f836c2ade44a ยท friendica/friendica
GitHubHypolite Petovan likes this.